Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tr064] Adds new channels for DSL Max & Current Down-/Upstream Rate #9519

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

sgiehl
Copy link
Contributor

@sgiehl sgiehl commented Dec 25, 2020

This PR adds the following new channels to the wan subdevice of tr064 binding

channel item-type description
dslDownstreamMaxRate Number:DataTransferRate DSL Max Downstream Rate
dslDownstreamCurrRate Number:DataTransferRate DSL Curr. Downstream Rate
dslUpstreamMaxRate Number:DataTransferRate DSL Max Upstream Rate
dslUpstreamCurrRate Number:DataTransferRate DSL Curr. Upstream Rate

I needed to add support for the data type i4, as that data type was returned for dslUpstreamCurrRate from my Fritz!Box 7390

Note: I've used to use the fritzboxtr064 binding, which is no longer usable with OH3. This binding had those channels available.

Signed-off-by: Stefan Giehl stefangiehl@gmail.com

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
@J-N-K J-N-K self-assigned this Dec 25, 2020
@J-N-K J-N-K linked an issue Dec 25, 2020 that may be closed by this pull request
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Dec 25, 2020
@J-N-K J-N-K changed the title [TR064] Adds new channels for DSL Max & Current Down-/Upstream Rate [tr064] Adds new channels for DSL Max & Current Down-/Upstream Rate Dec 25, 2020
@J-N-K J-N-K merged commit 291b309 into openhab:main Dec 25, 2020
@sgiehl
Copy link
Contributor Author

sgiehl commented Dec 25, 2020

Thanks for the fast approval 👍

@sgiehl sgiehl deleted the tr064dslupdown branch December 26, 2020 00:10
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
…penhab#9519)

Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@wborn wborn added this to the 3.1 milestone Jan 22, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-fritz-box-tr064-add-on-binding/108299/70

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tr064] Support for current downstream and upstream
4 participants