-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tr064] Adds new channels for DSL Max & Current Down-/Upstream Rate #9519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
tr064dslupdown
branch
from
December 25, 2020 19:47
9ef6c39
to
ffa0dd8
Compare
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
sgiehl
force-pushed
the
tr064dslupdown
branch
from
December 25, 2020 19:51
ffa0dd8
to
be09a79
Compare
J-N-K
changed the title
[TR064] Adds new channels for DSL Max & Current Down-/Upstream Rate
[tr064] Adds new channels for DSL Max & Current Down-/Upstream Rate
Dec 25, 2020
J-N-K
approved these changes
Dec 25, 2020
Thanks for the fast approval 👍 |
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
…penhab#9519) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
…penhab#9519) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh3-fritz-box-tr064-add-on-binding/108299/70 |
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…penhab#9519) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…penhab#9519) Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following new channels to the wan subdevice of tr064 binding
dslDownstreamMaxRate
Number:DataTransferRate
dslDownstreamCurrRate
Number:DataTransferRate
dslUpstreamMaxRate
Number:DataTransferRate
dslUpstreamCurrRate
Number:DataTransferRate
I needed to add support for the data type
i4
, as that data type was returned fordslUpstreamCurrRate
from my Fritz!Box 7390Note: I've used to use the fritzboxtr064 binding, which is no longer usable with OH3. This binding had those channels available.
Signed-off-by: Stefan Giehl stefangiehl@gmail.com